Hi,
On May 6 2018 04:03, Connor McAdams wrote:
Edit core functions to support the Sound Blaster Z and Recon3Di for
startup and loading of the DSP, as well as setting effects.
Signed-off-by: Connor McAdams <conmanx360@xxxxxxxxx>
---
sound/pci/hda/patch_ca0132.c | 1064 ++++++++++++++++++++++++++++++++++++++++--
1 file changed, 1018 insertions(+), 46 deletions(-)
In my opinion, this patch is too large. This patch can be split into
several parts:
* Changes for signature of 'dspio_scp()' to get 'src_id'
* dspio_scp()
* dspio_set_param()
* dspio_set_uint_param()
* dspio_alloc_dma_chan()
* dspio_free_dma_chan()
* Changes for SBZ only
* Changes for R3Di only
Could you please prepare for these three patches from this large patch
in your next chance? Especially, you can describe enough information to
the latter two patches as patch comment.
Thanks
Takashi Sakamoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
