On Monday 16 April 2018 10:52 PM, Mark Brown wrote:
On Fri, Mar 30, 2018 at 02:09:54AM +0530, Vijendar Mukunda wrote:
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@xxxxxxx>
Signed-off-by: Akshu Agrawal <akshu.agrawal@xxxxxxx>
Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
v1->v2: fixed kbuild errors
---
Please put inter-version changelogs after the --- as covered in
SubmittingPatches.
+#ifdef CONFIG_SND_DESIGNWARE_PCM
+ adata->i2s_capture_instance = dev->i2s_instance;
+#else
+ adata->i2s_capture_instance = I2S_SP_INSTANCE;
+#endif
These ifdefs aren't great - we should be able to build a single kernel
image that works on all systems so if we've got configuration options
based on the presence of other drivers then presumably existing systems
are going to be disrupted here. On the other hand if all systems are
able to use the Designware driver then we should just do that
unconditionally.
This will also break in cases where the Designware driver gets built as
a module.
I removed Ifdefs and further simplified DMA Driver design.
I had posted fresh series.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
