On Thu, Apr 05, 2018 at 07:29:11PM -0500, Pierre-Louis Bossart wrote:
> On 4/5/18 11:48 AM, Vinod Koul wrote:
> >+static int cdns_get_pdi(struct sdw_cdns *cdns,
> >+ struct sdw_cdns_pdi *pdi,
> >+ unsigned int num, u32 ch)
> >+{
> >+ int i, pdis = 0;
> >+ u32 ch_count = ch;
>
> redundant variable without added value...
ok will remove
> >+EXPORT_SYMBOL(sdw_cdns_alloc_stream);
>
> can you clarify the difference between _get_pdi and _find_pdi and
> alloc_stream/get_stream.
>
> It's pretty confusing.
Okay will add few notes and try to rename the functions.
--
~Vinod
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
