Re: [PATCH 2/5] ASoC: Intel: Headset button support in broxton machine driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2018-04-06 at 06:45 +0530, Naveen M wrote:
> 
> Thanks for the review and update. Shall correct this in V2.
> Also there are other machines which still use KEY_MEDIA -
> kbl_da7219_max98357a.c, cht_bsw_nau8824.c
> Shall correct these too.

kbl_da7219_max98357a and rk3399_gru_sound also seem to have
KEY_VOICECOMMAND on BTN_3 and volume up/down on 1/2; is that correct?

Until I spotted that, I was going to suggest a generic helper to set
all four, since they should *all* be setting the four events to
KEY_PLAYPAUSE, KEY_VOICECOMMAND, KEY_VOLUMEUP, KEY_VOLUMEDOWN
respectively.

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux