On Fri, Mar 30, 2018 at 12:05:00PM +0900, Takashi Sakamoto wrote: > Hi, > > On Mar 28 2018 18:38, Vinod Koul wrote: > > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > > index c0edac80df34..690e56a35237 100644 > > --- a/sound/soc/soc-core.c > > +++ b/sound/soc/soc-core.c > > @@ -2882,6 +2882,26 @@ int snd_soc_dai_set_tdm_slot(struct snd_soc_dai *dai, > > EXPORT_SYMBOL_GPL(snd_soc_dai_set_tdm_slot); > > /** > > + * snd_soc_dai_set_sdw_stream() - Configures a DAI for SDW stream operation > > + * @dai: DAI > > + * @stream: STREAM > > + * @direction: Stream direction(Playback/Capture) > > + * SoundWire subsystem doesn't have a notion of direction and we reuse > > + * the ASoC stream direction to configure sink/source ports. > > + * > > + * Returns 0 on success, a negative error code otherwise. > > + */ > > +int snd_soc_dai_set_sdw_stream(struct snd_soc_dai *dai, > > + void *stream, int direction) > > +{ > > + if (dai->driver->ops->set_sdw_stream) > > + return dai->driver->ops->set_sdw_stream(dai, stream, direction); > > + else > > + return -ENOTSUPP; > > +} > > +EXPORT_SYMBOL_GPL(snd_soc_dai_set_sdw_stream); > > It's better for this kind of code to be incline function in any header. In > general, new symbols increase maintenance cost of binary of kernel-related > stuffs. It's preferable to avoid the addition if possible, IMO. I don't understand, functionally it's the same, there should not be any increased maintenance either way. Please explain how this makes things "harder"? thanks, greg k-h _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel