Re: [PATCH] ALSA: pcm: Use dma_bytes as size parameter in dma_mmap_coherent()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 26 Mar 2018 16:10:21 +0200,
Stefan Roese wrote:
> 
> When trying to use the driver (e.g. aplay *.wav), the 4MiB DMA buffer
> will get mmapp'ed in 16KiB chunks. But this fails with the 2nd 16KiB
> area, as the page offset is outside of the VMA range (size), which is
> currently used as size parameter in snd_pcm_lib_default_mmap(). By
> using the DMA buffer size (dma_bytes) instead, the complete DMA buffer
> can be mmapp'ed and the issue is fixed.
> 
> This issue was detected on an ARM platform (TI AM57xx) using the RME
> HDSP MADI PCIe soundcard.
> 
> Signed-off-by: Stefan Roese <sr@xxxxxxx>
> Cc: Jaroslav Kysela <perex@xxxxxxxx>
> Cc: Takashi Iwai <tiwai@xxxxxxxx>
> Cc: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>

Applied now.

Thanks for catching this.  It was an itchy bug that has been standing
for long time.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux