On Sun, Mar 04, 2018 at 03:35:51PM +0100, Hans de Goede wrote: > +/* > + * Note these MUST match the values from the DT binding: > + * Documentation/devicetree/bindings/sound/rt5651.txt > + */ > enum rt5651_jd_src { > RT5651_JD_NULL, > RT5651_JD1_1, It's normal to put values like this in a header in include/dt-bindings so it's easy to get things right in actual DT bindings (and possibly ACPI tables as well if the machinery for that does the right thing) - can you send a followup doing that please? > -static const struct dmi_system_id rt5651_quirk_table[] = { > - { > - .callback = rt5651_quirk_cb, > - .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "KIANO"), > - DMI_MATCH(DMI_PRODUCT_NAME, "KIANO SlimNote 14.2"), > - }, > - .driver_data = (unsigned long *) RT5651_JD1_1, > - }, > - {} > -}; > - I'm still not thrilled about this bit but oh well :(
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel