>-----Original Message----- >From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@xxxxxxxxxxxxxxx] >Sent: Tuesday, February 27, 2018 12:44 AM >To: Ughreja, Rakesh A <rakesh.a.ughreja@xxxxxxxxx>; alsa-devel@alsa- >project.org; broonie@xxxxxxxxxx; tiwai@xxxxxxx; >liam.r.girdwood@xxxxxxxxxxxxxxx >Cc: Koul, Vinod <vinod.koul@xxxxxxxxx>; Patches Audio ><patches.audio@xxxxxxxxx> >Subject: Re: [PATCH v1 5/9] ALSA: hda - split snd_hda_codec_new >function > >On 2/26/18 1:28 AM, Ughreja, Rakesh A wrote: >> >> >>> -----Original Message----- >>> From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@xxxxxxxxxxxxxxx] >>> Sent: Friday, February 23, 2018 10:20 PM >>> To: Ughreja, Rakesh A <rakesh.a.ughreja@xxxxxxxxx>; alsa-devel@alsa- >>> project.org; broonie@xxxxxxxxxx; tiwai@xxxxxxx; >>> liam.r.girdwood@xxxxxxxxxxxxxxx >>> Cc: Koul, Vinod <vinod.koul@xxxxxxxxx>; Patches Audio >>> <patches.audio@xxxxxxxxx> >>> Subject: Re: [PATCH v1 5/9] ALSA: hda - split snd_hda_codec_new function >>> >>> On 2/23/18 2:12 AM, Rakesh Ughreja wrote: >>>> Split snd_hda_codec_new into two separate functions. >>>> snd_hda_codec_device_init allocates memory and registers with bus. >>>> snd_hda_codec_device_new initialializes the fields and performs >>>> snd_device_new. This enables reuse of legacy HDA codec drivers as ASoC >>>> codec drivers. >>>> >>>> In addition mark some functions with EXPORT_SYMBOL_GPL so that it can be >>>> called by ASoC codec drivers. >>> >>> I don't get the commit message. >>> You first say that we can now reuse legacy HDaudio codec drivers in an >>> ASoC framework, then say that there will be additional ASoC codec >>> drivers? Why would we do this, it seems like a contradicting goal? >>> >> >> Yes, its misleading, so correcting the line as, >> >> In addition mark some functions with EXPORT_SYMBOL_GPL so that it can be >> called by ASoC wrapper around the legacy HDA driver (hdac_hda). > >Still confusing. You are both reusing codec drivers and defining a >wrapper, so are you reusing parts of the codec drivers only? There is a kernel module called snd-hda-codec and it reused by all the legacy codec drivers. I am marking few additional functions with EXPORT_SYMBOL in the snd-hda-codec and not in the codec driver. These new additional functions are used by hdac_hda kernel module. Existing legacy codec driver is reused completely as it is and not in parts. Regards, Rakesh _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
