>-----Original Message----- >From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@xxxxxxxxxxxxxxx] >Sent: Friday, February 23, 2018 10:25 PM >To: Ughreja, Rakesh A <rakesh.a.ughreja@xxxxxxxxx>; alsa-devel@alsa- >project.org; broonie@xxxxxxxxxx; tiwai@xxxxxxx; >liam.r.girdwood@xxxxxxxxxxxxxxx >Cc: Koul, Vinod <vinod.koul@xxxxxxxxx>; Patches Audio ><patches.audio@xxxxxxxxx> >Subject: Re: [PATCH v1 8/9] ASoC: hdac_hda: add asoc extension for legacy HDA >codec drivers > >On 2/23/18 2:12 AM, Rakesh Ughreja wrote: >> This patch adds a kernel module which is used by the legacy HDA >> codec drivers as library. This implements hdac_ext_bus_ops to enable >> the reuse of legacy HDA codec drivers with ASoC platform drivers. >> >> Signed-off-by: Rakesh Ughreja <rakesh.a.ughreja@xxxxxxxxx> >> --- >> sound/pci/hda/hda_bind.c | 6 + >> sound/soc/codecs/Kconfig | 5 + >> sound/soc/codecs/Makefile | 2 + >> sound/soc/codecs/hdac_hda.c | 448 >++++++++++++++++++++++++++++++++++++++++++++ >> sound/soc/codecs/hdac_hda.h | 23 +++ >> 5 files changed, 484 insertions(+) >> create mode 100644 sound/soc/codecs/hdac_hda.c >> create mode 100644 sound/soc/codecs/hdac_hda.h > >so now we have both hdac_hdmi and hdac_hda? >Not sure I get it. hdac_hdmi is the ASoC HDMI driver which exists today. All the intel ASoC driver which are primarily used for I2S codecs uses it. I am not deleting or removing the support for that. hdac_hda is the ASoC wrapper around the legacy HDA drivers. Now with this patch series, we have two choices for HDMI/iDisp codec driver. Either to use the legacy HDMI codec driver by using the ASoC wrapper or use the existing ASoC hdac_hdmi driver. Since Intel ASoC platform driver is already proven and tested with ASoC hdac_hdmi driver, I am using that in this patch series. Regards, Rakesh _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel