On Mon, 05 Feb 2018 07:47:11 +0100,
Kirill Marinushkin wrote:
>
> Hello maintainers,
>
> I would like to suggest you a patch which fixes a typo in the alsa-utils
> alsaloop.
>
> Best Regards,
> Kirill Marinushkin
>
> Signed-off-by: Kirill Marinushkin <k.marinushkin@xxxxxxxxx>
> Cc: patch@xxxxxxxxxxxxxxxx
> Cc: alsa-devel@xxxxxxxxxxxxxxxx
Sorry for the late reply, as I've been (and still) on vacation.
About your patch: The fix itself looks OK, but could you give more
explanation about the change? E.g. what does this fix?
thanks,
Takashi
> ---
> alsaloop/pcmjob.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/alsaloop/pcmjob.c b/alsaloop/pcmjob.c
> index 69abf94..7de757b 100644
> --- a/alsaloop/pcmjob.c
> +++ b/alsaloop/pcmjob.c
> @@ -1479,7 +1479,7 @@ __again:
> if (loop->play->access == loop->capt->access &&
> loop->play->format == loop->capt->format &&
> loop->play->rate == loop->capt->rate &&
> - loop->play->channels == loop->play->channels &&
> + loop->play->channels == loop->capt->channels &&
> loop->sync != SYNC_TYPE_SAMPLERATE) {
> if (verbose > 1)
> snd_output_printf(loop->output, "shared buffer!!!\n");
> --
> 2.13.6
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
