>-----Original Message----- >From: Mark Brown [mailto:broonie@xxxxxxxxxx] >Sent: Wednesday, January 10, 2018 2:30 AM >To: Takashi Iwai <tiwai@xxxxxxx> >Cc: Ryan Lee <RyanS.Lee@xxxxxxxxxxxxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx; >lgirdwood@xxxxxxxxx; ryan.lee.maxim@xxxxxxxxx; perex@xxxxxxxx; linux- >kernel@xxxxxxxxxxxxxxx >Subject: Re: [PATCH 1/4] ASoC: max98373: Changed SPDX header in C++ >comments style > >On Wed, Jan 10, 2018 at 11:21:56AM +0100, Takashi Iwai wrote: >> Mark Brown wrote: >> > On Tue, Jan 09, 2018 at 09:01:58PM -0800, Ryan Lee wrote: > >> > > @@ -1,4 +1,4 @@ >> > > -/* SPDX-License-Identifier: GPL-2.0 */ >> > > +// SPDX-License-Identifier: GPL-2.0 >> > > /* Copyright (c) 2017, Maxim Integrated */ > >> > Please change the entire header to C++, mixing C and C++ on adjacent >> > lines looks ugly. > >> I'm not sure whether it's a good direction to go, either. > >> I rather wonder why SPDX line *must* be in C++ comment style... > >Apparently it's to remove any ambiguity for the tooling or something, plus Linus >decided he likes C++ comments. > >I don't understand why this isn't done as a macro like MODULE_LICENSE() and >so on but the decision was rushed through and not really publicised >:9 Thank you for your feedback. I modified two header lines in C++ comment style and send it again. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
