Hi Peter
Thank you for you review
> > Note:
> > xxx_codec_xxx() -> xxx_component_xxx()
> > .idle_bias_off = 1 -> .idle_bias_on = 0
> > .ignore_pmdown_time = 0 -> .pmdown_time = 1
> > - -> .endianness = 1
> > - -> .non_legacy_dai_naming = 1
>
> The pmdown_time was 5000 by default (see soc-core.c).
> Ah, in snd_soc_component_driver the pmdown_timme is _not_ pmdown_time,
> but use_pmdown_time boolean...
Ahh, naming... hmm.. Yes, indeed.
Mark, I know you still not yet accepting these.
We can have 2nd chance to name it ?
> > +static const struct snd_soc_component_driver soc_component_dev_twl4030 = {
> > + .probe = twl4030_soc_probe,
> > + .remove = twl4030_soc_remove,
> > + .set_bias_level = twl4030_set_bias_level,
> > + .controls = twl4030_snd_controls,
> > + .num_controls = ARRAY_SIZE(twl4030_snd_controls),
> > + .dapm_widgets = twl4030_dapm_widgets,
> > + .num_dapm_widgets = ARRAY_SIZE(twl4030_dapm_widgets),
> > + .dapm_routes = intercon,
> > + .num_dapm_routes = ARRAY_SIZE(intercon),
> > + .pmdown_time = 1,
> > + .endianness = 1,
> > + .non_legacy_dai_naming = 1,
>
> We need the .read and .write back first, as the removal of those broke
> twl4030 and twl6040.
Yes.
I will post v2 patch if Mark accepted Tony's patch
Best regards
---
Kuninori Morimoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
