On Sun, Jan 14, 2018 at 8:21 PM, Nicolin Chen <nicoleotsuka@xxxxxxxxx> wrote: > ==Change log== > v3 > * Reworked the series by taking suggestions from Maciej > + Added PATCH-01 to make RX and TX more clearly defined > + Replaced "bool dir" with "int dir" in PATCH-04 > + Replaced "!dir" with "int adir" in PATCH-05 > + Put CBM_CFS behind the baudclk check to keep the same > program flow in PATCH-14 > + Removed all cpu_dai_drv changes in PATCH-15 > v2 > * Reworked the series by taking suggestions from Maciej > + Added PATCH-01 to keep all ssi->i2s_net updated > + Replaced bool tx with bool dir in PATCH-03 and PATCH-06 > + Moved all initial register configurations from dai probe() to > platform probe() so as to let AC97 CODEC successfully probe. > * Added Tested-by from Caleb for TDM test cases. > > ==Background== > The fsl_ssi driver was designed for PPC originally and then it has > been updated to support different modes for i.MX Series, including > SDMA, I2S Master mode, AC97 and older i.MXs with FIQ, by different > contributors for different use cases in different coding styles. > > Additionally, in order to fix/work-around hardware bugs and design > flaws, the driver made a lot of compromise so now its program flow > looks very complicated and it's getting hard to maintain or update. > > So I am going to clean up the driver on both coding style level and > program flow level. > > ==Introduction== > This series of patches is the second set to clean up fsl_ssi driver > in the program flow level. Any patch here may impact a fundamental > test case like playback or record. > > ==Verification== > This series of patches require fully tested. I have done such tests > on i.MX6SoloX with WM8962 using imx_v6_v7_defconfig as: > - Playback via I2S Master and Slave mode > - Record via I2S Master and Slave mode > - Simultaneous playback and record via I2S Master and Slave mode > - Background playback with foreground record (starting at different > time) via I2S Master and Slave mode > - Background record with foreground playback (starting at different > time) via I2S Master and Slave mode > * All tests above by hacking offline_config to true in imx51. > > Caleb has tested v1 with TDM lookback tests on i.MX6. > > Example of uncovered tests: AC97, PowerPC and FIQ. > > Nicolin Chen (17): > ASoC: fsl_ssi: Redefine RX and TX macros > ASoC: fsl_ssi: Keep ssi->i2s_net updated > ASoC: fsl_ssi: Clean up set_dai_tdm_slot() > ASoC: fsl_ssi: Maintain a mask of active streams > ASoC: fsl_ssi: Rename fsl_ssi_disable_val macro > ASoC: fsl_ssi: Clear FIFO directly in fsl_ssi_config() > ASoC: fsl_ssi: Clean up helper functions of trigger() > ASoC: fsl_ssi: Add DAIFMT define for AC97 > ASoC: fsl_ssi: Clean up fsl_ssi_setup_regvals() > ASoC: fsl_ssi: Set xFEN0 and xFEN1 together > ASoC: fsl_ssi: Use snd_soc_init_dma_data instead > ASoC: fsl_ssi: Move one-time configurations to probe() > ASoC: fsl_ssi: Setup AC97 in fsl_ssi_hw_init() > ASoC: fsl_ssi: Clean up _fsl_ssi_set_dai_fmt() > ASoC: fsl_ssi: Add bool synchronous to mark synchronous mode > ASoC: fsl_ssi: Move DT related code to a separate probe() > ASoC: fsl_ssi: Use ssi->streams instead of reading register > > sound/soc/fsl/fsl_ssi.c | 733 ++++++++++++++++++++++++------------------------ > sound/soc/fsl/fsl_ssi.h | 3 - > 2 files changed, 370 insertions(+), 366 deletions(-) > > -- > 2.7.4 > tested v3... Tested-by: Caleb Crome <caleb@xxxxxxxxx> _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
