On Mon, 2018-01-08 at 14:28 -0600, Pierre-Louis Bossart wrote: > On 1/7/18 10:41 PM, Vinod Koul wrote: > > On Fri, Jan 05, 2018 at 02:55:36PM -0600, Pierre-Louis Bossart > > wrote: > > > Remove hard-coded [16] array size, replace with clearer > > > description and > > > dependency on ACPI_ID_LEN > > > > > > > > > +/* codec name is used in DAIs is i2c-<HID>:00 with HID being 8 > > > chars */ > > > +#define SND_SOC_ACPI_I2C_DEVICE_NAME_LEN (4 + ACPI_ID_LEN + 3 + > > > 1) > > > > nitpicking, thats a very long name :( > > > > how about SND_ACPI_I2C_ID_LEN, we can drop SOC. And replace > > DEVICE_NAME with ID > > Fine with me. Andy do you concur or have a more precise suggestion? Looks sane to me. Thank you, Vinod, for a suggestion. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
