On Thu, 2018-01-04 at 09:24 -0600, Pierre-Louis Bossart wrote:
> On 1/4/18 8:57 AM, Andy Shevchenko wrote:
> > On Wed, 2018-01-03 at 11:02 -0600, Pierre-Louis Bossart wrote:
> > >
> > > Fix by overriding the hard-coded value with the codec name derived
> > > from the HID information
> >
> > The patch makes me think about introducing acpi_dev_get_dev_name()
> > and
> > utilize it here since I need something similar to have in one of
> > GPIO
> > drivers.
>
> we use this: snd_soc_acpi_find_name_from_hid(mach->id)
>
> When I started all this the recommendation was to do all this on the
> audio side of things, I have no objections to a move of the
> functionality in acpi.
I almost done a patch. I will Cc you for the series.
> > > +static char codec_name[16]; /* i2c-<HID>:00 with HID being 8
> > > chars */
> > > +
> >
> > I would rather do use 4 + ACPI_ID_LEN + 3 /* or 1 + 2 */ + 1 and
> > explain
> > each part in the comment above.
>
> yes we could do this. this is the same code as in other machine
> drivers,
> so we should do the replacement across all of them in one shot in a
> separate patch.
Whatever you prefer, it's minor.
> > > + mach = (&pdev->dev)->platform_data;
> > > + /* fix index of codec dai */
> > > + for (i = 0; i < ARRAY_SIZE(byt_cht_es8316_dais); i++) {
> > > + if (!strcmp(byt_cht_es8316_dais[i].codec_name,
> > > + "i2c-ESSX8316:00")) {
> > > + dai_index = i;
> > > + break;
> > > + }
> >
> > Perhaps at some point you can do such in more generic (across Intel
> > ASoCs) ?
>
> Not sure what you are hinting at here? Did you mean changing the name
> of
> the array? Or adding a helper function to do this?
Suggestion is to create a helper out of similar for-loops-fix-name in
all current users.
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
