> -----Original Message----- > From: Mark Brown [mailto:broonie@xxxxxxxxxx] > Sent: Wednesday, January 03, 2018 6:51 PM > To: Hans de Goede > Cc: Bard Liao; Oder Chiou; Takashi Iwai; alsa-devel@xxxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/6] ASoC: rt5645: change micbias widget type to supply. > > On Tue, Jan 02, 2018 at 07:53:09PM +0100, Hans de Goede wrote: > > > Register "micbias1" and "micbias2" to supply widegts as modern drivers do. > > > - SND_SOC_DAPM_MICBIAS("micbias1", RT5645_PWR_ANLG2, > > - RT5645_PWR_MB1_BIT, 0), > > - SND_SOC_DAPM_MICBIAS("micbias2", RT5645_PWR_ANLG2, > > - RT5645_PWR_MB2_BIT, 0), > > + SND_SOC_DAPM_SUPPLY("micbias1", RT5645_PWR_ANLG2, > > + RT5645_PWR_MB1_BIT, 0, NULL, 0), > > + SND_SOC_DAPM_SUPPLY("micbias2", RT5645_PWR_ANLG2, > > + RT5645_PWR_MB2_BIT, 0, NULL, 0), > > This is a good change to make but we have machines with the rt5645, are > we sure none of them use microphones? The two widget types work > differently so it needs some checking and possibly machine driver > updates to convert. It's late today. I will check it tomorrow. I will send patches for those machine driver and device tree which use rt5645 or rt5650 micbias. > > ------Please consider the environment before printing this e-mail. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
