Re: [PATCH v1 1/1] ASoC: rsnd: ssi: Fix issue in dma data address assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Morimoto-san

On 12/20/2017 11:39 PM, Kuninori Morimoto wrote:
Hi Jiada

diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index a298df7..16f3214 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -94,14 +94,24 @@
         };

         rsnd_ak4613: sound {
-               compatible = "simple-audio-card";
+               compatible = "simple-scu-audio-card";

                 simple-audio-card,format = "left_j";
                 simple-audio-card,bitclock-master =<&sndcpu>;
                 simple-audio-card,frame-master =<&sndcpu>;

-               sndcpu: simple-audio-card,cpu {
-                       sound-dai =<&rcar_sound>;
+               simple-audio-card,prefix = "ak4613";
+                simple-audio-card,routing =
+                        "ak4613 Playback", "DAI0 Playback",
+                        "DAI0 Capture", "ak4613 Capture",
+                        "ak4613 Playback", "DAI1 Playback";
+
+               sndcpu: simple-audio-card,cpu@0 {
+                       sound-dai =<&rcar_sound 0>;
+               };
+
+               simple-audio-card,cpu@1 {
+                       sound-dai =<&rcar_sound 1>;
                 };

                 sndcodec: simple-audio-card,codec {
@@ -517,7 +527,7 @@
         pinctrl-names = "default";

         /* Single DAI */
-       #sound-dai-cells =<0>;
+       #sound-dai-cells =<1>;

         /* audio_clkout0/1/2/3 */
  #clock-cells =<1>;
@@ -549,6 +559,9 @@
                         playback =<&ssi0&src0&dvc0>;
                         capture  =<&ssi1&src1&dvc1>;
                 };
+               dai1 {
+                       playback =<&ssi0>;
+               };
         };
  };

playing with dai1 will have issue.
I guess so because you are using strange settings...
What do you want to do ?
this is just an example setting to reproduce the issue with current mainline kernel,

We have enabled TDM Split and Ex-Split mode in our kernel,
and SSI(U)'s dma address diffs based on the BUSIF it is using,
so have a single dma data struct per rsnd_ssi will cause issue when
SSI isn't working with BUSIF0.

Do you have any suggestion to address this issue?


Thanks,
Jiada
Best regards
---
Kuninori Morimoto

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux