Hi, I am outside so can't use mutt. Sorry for that. This comment is going to be replaced in the 2nd set anyway because the whole function will be replaced. And please point out all comments that you think I need to rework. I am totally fine to do that. I don't think every single one is bad. And this patch has to go in as it also adds a lot of new comments. Thank you for your effort Nicolin On Dec 15, 2017 20:43, "Timur Tabi" <timur@xxxxxxxx> wrote: On 12/13/17 5:18 PM, Nicolin Chen wrote: > - * We are running on a SoC which does not support online SSI > - * reconfiguration, so we have to enable all necessary flags at > once > - * even if we do not use them later (capture and playback > configuration) > + * Online configuration is not supported > + * Enable or Disable all necessary bits at once > This is an example of a bad change, IMHO. The original was written in elegant prose. The new version is just two short sentences. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
