On Thu, Dec 14, 2017 at 03:31:39PM +0000, Mark Brown wrote: > On Thu, Dec 14, 2017 at 11:56:48AM +0000, Charles Keepax wrote: > > On Wed, Dec 13, 2017 at 08:37:30PM +0800, Chen.Liu wrote: > > > > + if (unsupported) > > > + snd_soc_update_bits(codec, WM8960_CLOCK1, 0x6, > > > + WM8960_SYSCLK_DIV_2); > > > + > > > Looking at this a bit more I do have some reservations. Firstly > > this divider can be set through wm8960_set_dai_clkdiv, and > > secondly it is also set at the bottom of > > Removing set_clkdiv() would be a better thing if there were conflicts > here, in general we're trying to avoid uses of it. Ok that can probably be done as a separate patch I will review again with that in mind. Thanks, Charles _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
