>-----Original Message----- >From: alsa-devel-bounces@xxxxxxxxxxxxxxxx [mailto:alsa-devel-bounces@alsa- >project.org] On Behalf Of Takashi Iwai >Sent: Tuesday, December 12, 2017 10:21 PM >To: Ughreja, Rakesh A <rakesh.a.ughreja@xxxxxxxxx> >Cc: alsa-devel@xxxxxxxxxxxxxxxx; Koul, Vinod <vinod.koul@xxxxxxxxx>; pierre- >louis.bossart@xxxxxxxxxxxxxxx; liam.r.girdwood@xxxxxxxxxxxxxxx; Patches Audio ><patches.audio@xxxxxxxxx>; broonie@xxxxxxxxxx >Subject: Re: [RFC v2 00/11] Enable HDA Codec support on Intel >Platforms (Series2) > > >The idea looks good, but I'd prefer different functions instead of >mutating the behavior depending on the flag. i.e. keep >snd_hda_codec_new(), and introduce another API (snd_hda_codec_init() >or whatever). ASoC driver can call the latter while the legacy driver >keeps calling the former. > >This would factor out the allocation and snd_hdac_device_init() calls >from the old snd_hda_codec_new() to a new snd_hda_codec_new(). >snd_hda_codec_init() would do the rest. snd_hda_codec_new() calls >snd_hda_codec_init() at the end of the function. > >Does this sound good for you? I think I got this :) Thanks. Here is the skeleton code. I split the existing function snd_hda_codec_new into two parts. 1. snd_hda_codec_device_init() 2. snd_hda_codec_device_new() So the new body of existing function snd_hda_codec_new looks like. int snd_hda_codec_new(struct hda_bus *bus, struct snd_card *card, unsigned int codec_addr, struct hda_codec **codecp) { int ret; ret = snd_hda_codec_device_init(bus, card, codec_addr, codecp); if (ret < 0) return ret; return snd_hda_codec_device_new(bus, card, codec_addr, *codecp); } The ASoC driver would call only snd_hda_codec_device_new. If you have any suggestions for the function names, I can change it before I post the next series. Now switching over to the id_table problem. In the current series it is accessed using extern, in the patch_realtek.c file. So we really have two different KO files. One for legacy HDA driver and second for ASoC HDA driver. Would you like to keep them as two separate KO files or prefer to have a single KO file ? _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
