On Thu, Nov 30, 2017 at 12:42:30PM +0100, Philippe Ombredanne wrote: > On Thu, Nov 30, 2017 at 10:56 AM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote: > [] > > diff --git a/drivers/soundwire/bus.h b/drivers/soundwire/bus.h > > new file mode 100644 > > index 000000000000..2af05b21961e > > --- /dev/null > > +++ b/drivers/soundwire/bus.h > > @@ -0,0 +1,57 @@ > > +/* > > + * This file is provided under a dual BSD/GPLv2 license. When using or > > + * redistributing this file, you may do so under either license. > > + * > > + * SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) > > + * > > + * GPL LICENSE SUMMARY > > + * > > + * Copyright(c) 2015-17 Intel Corporation. > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of version 2 of the GNU General Public License as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, but > > + * WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * General Public License for more details. > > + * > > + * BSD LICENSE > > + * > > + * Copyright(c) 2015-17 Intel Corporation. > > + * > > + * Redistribution and use in source and binary forms, with or without > > + * modification, are permitted provided that the following conditions > > + * are met: > > + * > > + * * Redistributions of source code must retain the above copyright > > + * notice, this list of conditions and the following disclaimer. > > + * * Redistributions in binary form must reproduce the above copyright > > + * notice, this list of conditions and the following disclaimer in > > + * the documentation and/or other materials provided with the > > + * distribution. > > + * * Neither the name of Intel Corporation nor the names of its > > + * contributors may be used to endorse or promote products derived > > + * from this software without specific prior written permission. > > + * > > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > + * > > + */ > > Hi Vinod, > > You may want to use the proper SPDX ids convention here instead? e.g. > below is all you need IMHO: not 50 lines of boilerplate but only two. > > You will make everyone happier with a sigh of relief when you remove > this boilerplate, and you will also have saved a few trees if this > ever printed on paper, making earth a better planet as a bonus ;) > > > +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) > > +// Copyright (c) 2015-17 Intel Corporation. I hadn't seen this one, thanks for pointing. A quick google pointed me to relevant post. > Neater and simpler, is it not? In any case the SPDX line should go at the top. > See Linus and tglx doc posts for comment and doc styles for this. > NB: some includes used in assembly sometimes require to use /**/ > comments instead. IANAL and recommendation at Intel is to keep the text with the tags. Thanks -- ~Vinod _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
