>> Add a jump target so that a bit of exception handling can be better reused >> in an if branch of this function. … > Hmm. Doesn't really gain an awful lot this. I show just another small change possibility. > Would understand if there were multiple return paths, > but in that case I'd have implemented something like this anyway. Where? Can the suggested software refactoring become useful also for this function implementation? > Also your patch description isn't really correct. Which wording would you find more appropriate? > You're re-using code from the sunny day scenario to handle an exception. Can this detail be better? Regards, Markus _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
