On Thu, Nov 16, 2017 at 06:32:35PM +0530, Vinod Koul wrote: > On Thu, Nov 16, 2017 at 12:04:37PM +0000, Mark Brown wrote: > > On Fri, Nov 10, 2017 at 05:19:09PM +0530, Vinod Koul wrote: > > > +EXPORT_SYMBOL(__regmap_init_sdw); > > We still have plain EXPORT_SYMBOL() on the regmap exports... > I assumed after Alan's clarification that it is okay to do so. Let me know if > you feel otherwise No, I'm not which is why I replied to Alan's most recent mail explaining that I felt he was missing my point. For the bus code itself I don't really care either way, this is just about this one file. To repeat this is a pretty thin layer of code tying regmap and Soundwire together, it's not as substantial as the bus code itself. The exports have no meaning outside of a kernel context and within that context it's hard to see a natural use case for doing this. It's much easier to see cases where someone causes themselves problems by reading too much into the use of plain EXPORT_SYMBOL(), perhaps not considering things as carefully as they might otherwise have done.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
