On Fri, Nov 10, 2017 at 10:29:51AM +0530, Vinod Koul wrote: > On Thu, Nov 09, 2017 at 09:14:07PM +0000, Srinivas Kandagatla wrote: > > > > > > On 19/10/17 04:03, Vinod Koul wrote: > > >This adds the base SoundWire bus type, bus and driver registration. > > >along with changes to module device table for new SoundWire > > >device type. > > > > > >Signed-off-by: Sanyog Kale <sanyog.r.kale@xxxxxxxxx> > > >Signed-off-by: Vinod Koul <vinod.koul@xxxxxxxxx> > > >--- > > > > >+++ b/drivers/soundwire/Kconfig > > >@@ -0,0 +1,22 @@ > > >+# > > >+# SoundWire subsystem configuration > > >+# > > >+ > > >+menuconfig SOUNDWIRE > > >+ bool "SoundWire support" > > > > Any reason why this subsystem can not be build as module? > > This is not subsystem symbol but the menu. The SOUNDWIRE_BUS can be module. > > > > > >+ ---help--- > > >+ SoundWire is a 2-Pin interface with data and clock line ratified > > >+ by the MIPI Alliance. SoundWire is used for transporting data > > >+ typically related to audio functions. SoundWire interface is > > > > >+#ifndef __SDW_BUS_H > > >+#define __SDW_BUS_H > > >+ > > >+#include <linux/init.h> > > >+#include <linux/device.h> > > >+#include <linux/module.h> > > >+#include <linux/mod_devicetable.h> > > >+#include <linux/acpi.h> > > Do you need these headers here? > > Yes :) I will double check though > > > > > > >+#include <linux/soundwire/sdw.h> > > >+ > > >+int sdw_slave_modalias(struct sdw_slave *slave, char *buf, size_t size); > > >+ > > >+#endif /* __SDW_BUS_H */ > > >diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c > > >new file mode 100644 > > >index 000000000000..a14d1de80afa > > >--- /dev/null > > >+++ b/drivers/soundwire/bus_type.c > > > > > >+#include <linux/acpi.h> > > >+#include <linux/device.h> > > >+#include <linux/init.h> > > >+#include <linux/module.h> > > >+#include <linux/mod_devicetable.h> > > >+#include <linux/pm_domain.h> > > >+#include <linux/pm_runtime.h> > > >+#include <linux/soundwire/sdw.h> > > >+#include "bus.h" > > >+ > > >+/** > > >+ * sdw_get_device_id: find the matching SoundWire device id > > >+ * > > function name should end with () - according to kernel doc. > > ah thanks for pointing will add I ran the kernel-doc script, seems to not complain about this. Looking at it closely scripts/kernel-doc parenthesis is not expected -- ~Vinod _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
