Re: [PATCH 2/3] ASoC: wm8741: Set OSR mode in hw_params()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 19 Sep 2017 10:47:56 +0100, Charles Keepax wrote:
On Mon, Sep 18, 2017 at 09:30:36PM +0200, Sergej Sawazki wrote:
Am 06.09.2017 um 10:20 schrieb Charles Keepax:
...

I think we should split "adding the OSR mode configuration" and
"refactoring the code to use update_bits()" in at least two commits.

For consistency, I would keep the write() in this patch, and provide
the update_bits() refactoring later. What do you think?


Two commits seems sensible although its only a very small
refactoring so feels like we might as well get it done whilst
changing the code. I am happy to do the initial refactoring
patch, if that helps but I don't presently have hardware to test
this CODEC.


Thanks Charles,

I have the hardware and could make the tests if you provide initial
refactoring patch.

Regards
Sergej
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux