Re: [PATCH] ASoC: Intel: sst: remove redundant variable dma_dev_name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/19/2017 07:33 AM, Colin King wrote:
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

The pointer dma_dev_name is assigned but never read, it is redundant
and can therefore be removed.

Cleans up clang warning:
sound/soc/intel/common/sst-firmware.c:288:3: warning: Value stored to
'dma_dev_name' is never read

Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Indeed this has been unused since at least 2015...
FWIW
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>

---
  sound/soc/intel/common/sst-firmware.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/sound/soc/intel/common/sst-firmware.c b/sound/soc/intel/common/sst-firmware.c
index a086c35f91bb..79a9fdf94d38 100644
--- a/sound/soc/intel/common/sst-firmware.c
+++ b/sound/soc/intel/common/sst-firmware.c
@@ -274,7 +274,6 @@ int sst_dma_new(struct sst_dsp *sst)
  	struct sst_pdata *sst_pdata = sst->pdata;
  	struct sst_dma *dma;
  	struct resource mem;
-	const char *dma_dev_name;
  	int ret = 0;
if (sst->pdata->resindex_dma_base == -1)
@@ -285,7 +284,6 @@ int sst_dma_new(struct sst_dsp *sst)
  	* is attached to the ADSP IP. */
  	switch (sst->pdata->dma_engine) {
  	case SST_DMA_TYPE_DW:
-		dma_dev_name = "dw_dmac";
  		break;
  	default:
  		dev_err(sst->dev, "error: invalid DMA engine %d\n",

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux