On Thu, Oct 19, 2017 at 05:15:25AM +0530, Ughreja, Rakesh A wrote: > From: Rakesh Ughreja <rakesh.a.ughreja@xxxxxxxxx> > > Due to bugs in BIOS it's possible that the HDA capability link It maybe due to BIOS bug or some other issue, lets not quantify that please. I would say "On reading wrong capablity pointer values we may crash... > list is not constructed properly. This may lead to driver going > into unknown state. I dont think we maintain driver states which are going wrong here > So whenever driver discovers unknown HDA > capability, log it as error and stop traversing the link list > further. that sound good > > Signed-off-by: Rakesh Ughreja <rakesh.a.ughreja@xxxxxxxxx> > --- > sound/hda/hdac_controller.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c > index 978dc18..8f7d0d9 100644 > --- a/sound/hda/hdac_controller.c > +++ b/sound/hda/hdac_controller.c > @@ -314,7 +314,8 @@ int snd_hdac_bus_parse_capabilities(struct hdac_bus *bus) > break; > > default: > - dev_dbg(bus->dev, "Unknown capability %d\n", cur_cap); > + dev_err(bus->dev, "Unknown capability %d\n", cur_cap); > + cur_cap = 0; > break; > } > > -- > 2.7.4 > -- ~Vinod _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
