On 04/10/17 11:37, Mark Brown wrote: > On Mon, Oct 02, 2017 at 10:58:52AM +0100, Ed Blake wrote: > >> i2s->dai_driver.probe = img_i2s_in_dai_probe; >> + i2s->dai_driver.suspend = img_i2s_in_dai_suspend; >> + i2s->dai_driver.resume = img_i2s_in_dai_resume; > Why use the ASoC specific power management callbacks and not the system > ones? It does also look a bit like there's a case for converting the > driver to regmap and using the regmap cache code. Looking at other drivers, most seemed to use the ASoC specific callbacks. Are the system ones preferred? If so I'll change it for v2. > It does also look a bit like there's a case for converting the > driver to regmap and using the regmap cache code. Is it ok to do this in a future patch? Ed. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
