Hello Kuninori Morimoto,
This is a semi-automatic email about new static checker warnings.
The patch a0ac44115223: "ASoC: soc-core: add snd_soc_rtdcom_xxx()"
from Aug 8, 2017, leads to the following Smatch complaint:
sound/soc/soc-core.c:644 soc_free_pcm_runtime()
error: we previously assumed 'rtd' could be null (see line 642)
sound/soc/soc-core.c
641 {
642 if (rtd && rtd->codec_dais)
^^^
Check for NULL.
643 kfree(rtd->codec_dais);
644 snd_soc_rtdcom_del_all(rtd);
^^^
The check adds a new unchecked dereference inside the function. It's
weird that we call INIT_LIST_HEAD(&rtd->component_list), btw. Don't we
need to free the elements in the list?
645 kfree(rtd);
646 }
regards,
dan carpenter
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
