Re: [PATCH 5/9] ASoC: max98927: Removed obsolete variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 28, 2017 at 04:30:57PM -0700, Ryan Lee wrote:
> Signed-off-by: Ryan Lee <ryans.lee@xxxxxxxxxxxxxxxxxxx>

Why are these variables obsolete?  If their use was removed in earlier
patches in the series they should be handled in that patch, if they're
just unused say so.  In general your changelogs could really benefit
from being a bit longer and explaining why changes are being made.

>  mode change 100644 => 100755 sound/soc/codecs/max98927.h

This also changes the permissions to be executable which isn't what we
want.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux