On Tue, Aug 15, 2017 at 03:19:54PM +0300, Anton Vasilyev wrote: > If (quirks & QUIRK_SEC_DAI == 0) then samsung_i2s_probe() doesn't allocate > sec_dai and pri_dai->sec_dai remains Null, but samsung_i2s_remove() > performs pri_dai->sec_dai dereference in any case. > > The patch removes useless reinitialization of sec_dai at > samsung_i2s_remove(), because resources are under devm control. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Anton Vasilyev <vasilyev@xxxxxxxxx> > --- > v2: Drop initialization of sec_dai by NULL at samsung_i2s_remove > as Sylwester Nawrocki suggest. > --- > v3: Fix typo in the comment > --- > v4: Change comment based on Krzysztof review. > --- > sound/soc/samsung/i2s.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Best regards, Krzysztof _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
