Re: [PATCH] ASoC: compress: Remove duplicated code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2017-08-07 at 16:42 +0100, Mark Brown wrote:
> On Mon, Aug 07, 2017 at 10:28:30AM -0500, Pierre-Louis Bossart wrote:
> > On 8/7/17 10:07 AM, Mark Brown wrote:
> 
> > > Are you sure that this is the assignment that should be deleted, and if
> > > so why?  Note that it's both conditionally and unconditionally assigned
> > > later on...  Some words in the commit log about why this copy is removed
> > > would be helpful.
> 
> > Thanks for the report. Yes, the logic escapes me as well, there were two
> > separate changes from Liam and Richard Fitzgerald and I can't figure out why
> > the reassignments of the variable new_name are required.
> 
> I've got a feeling it was people not working and testing against
> mainline independently trying to fix similar issues and ending up
> colliding when things went upstream.

Yeah, probably Richard and I working on something similar in the past. 

Liam

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux