On Fri, 30 Jun 2017 21:59:01 +0200,
Gustavo A. R. Silva wrote:
>
> platform_get_irq() returns an error code, but the sata_rcar driver
> ignores it and always returns -ENODEV.
Which driver? A copy&paste error?
Takashi
> This is not correct, and
> prevents -EPROBE_DEFER from being propagated properly. Also,
> notice that platform_get_irq() no longer returns 0 on error.
>
> Print and propagate the return value of platform_get_irq on failure.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
> ---
> sound/x86/intel_hdmi_audio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
> index c19efc9..a095150 100644
> --- a/sound/x86/intel_hdmi_audio.c
> +++ b/sound/x86/intel_hdmi_audio.c
> @@ -1758,8 +1758,8 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev)
> /* get resources */
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "Could not get irq resource\n");
> - return -ENODEV;
> + dev_err(&pdev->dev, "Could not get irq resource: %d\n", irq);
> + return irq;
> }
>
> res_mmio = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> --
> 2.5.0
>
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
