Re: Applied "ASoC: rockchip: Fix an error handling in 'rockchip_i2s_probe'" to the asoc tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 16, 2017 at 06:57:30AM +0200, Christophe JAILLET wrote:
> Le 15/06/2017 à 19:20, Mark Brown a écrit :

> >   	if (!of_property_read_u32(node, "rockchip,playback-channels", &val)) {
> >   		if (val >= 2 && val <= 8)
> >   			soc_dai->playback.channels_max = val;

> ... and 'err' should be 'ret'...

> I'm really confused for such a ugly proposal !

In a situation like this it's generally best to send a patch, I'll fix
though.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux