On Sun, May 14, 2017 at 3:11 AM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Fri, May 05, 2017 at 10:42:15AM -0700, Ryan Lee wrote: >> Signed-off-by: Ryan Lee <ryans.lee@xxxxxxxxxxxxxxxxxxx> >> --- > > The subject line suggests that this is adding two new features. Unless > they are very closely related in the code they should be submitted as > separate patches as covered in SubmittingPatches. Thank you for your feedback. I separated this patch to five separate patches. > >> default: >> - dev_err(codec->dev, "DAI clock mode unsupported"); >> + dev_err(codec->dev, "DAI clock mode unsupported\n"); >> return -EINVAL; >> } >> > > It also seems like there are a number of unrelated stylistic changes in > this patch. While it's fine to make such changes they too should be in > separate patches. I applied this to separate patch. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
