On 4/24/17 4:45 PM, Takashi Iwai wrote:
On Mon, 24 Apr 2017 23:39:47 +0200,
Pierre-Louis Bossart wrote:
On 04/24/2017 07:09 AM, Takashi Iwai wrote:
The FE setups of Intel SST bytcr_rt5640 and bytcr_rt5651 drivers carry
the ignore_suspend flag, and this prevents the suspend/resume working
properly while the stream is running, since SST core code has the
check of the running streams and returns -EBUSY. Drop these
superfluous flags for fixing the behavior.
Also, the bytcr_rt5640 driver lacks of nonatomic flag in some FE
definitions, which leads to the kernel Oops at suspend/resume like:
This patch also fixes the known bug that reboot had to be forced on
some BYT platforms with a manual restart when the audio driver was
enabled.
Thanks Takashi!
While we're at it: could you submit the UCM profiles as alsa-lib
upstream? At least the ones for the drivers that are in the current
kernel should be merged.
If there are multiple board-specific UCMs for the same driver, we can
use now card's longname (generated from DMI string) as the primary
source, while keeping the $DRIVER/$DRIVER.conf as the fallback.
Well I've lost track of which git repo UCM files should be in, both the
license and the update rate of alsa-lib are problematic for
configuration files. We also talked about some include capabilities to
avoid copy/paste but I can't recall having seen them upstream.
I also haven't had time to test the long name on my devices.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
