I don't think the patch is correct, so I haven't bothered signing off on
it. Probably the & is not correct in the IS_ERR call?
julia
---------- Forwarded message ----------
Date: Sat, 22 Apr 2017 06:09:26 +0800
From: kbuild test robot <fengguang.wu@xxxxxxxxx>
To: kbuild@xxxxxx
Cc: Julia Lawall <julia.lawall@xxxxxxx>
Subject: [PATCH] ASoC: fix odd_ptr_err.cocci warnings
PTR_ERR should access the value just tested by IS_ERR
Semantic patch information:
There can be false positives in the patch case, where it is the call to
IS_ERR that is wrong.
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Simon Ho <simon.ho@xxxxxxxxxxxx>
Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
---
Please take the patch only if it's a positive warning. Thanks!
cx2072x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/sound/soc/codecs/cx2072x.c
+++ b/sound/soc/codecs/cx2072x.c
@@ -2183,7 +2183,7 @@ static int cx2072x_i2c_probe(struct i2c_
&cx2072x_regmap);
if (IS_ERR(&cx2072x->regmap)) {
- ret = PTR_ERR(cx2072x->regmap);
+ ret = PTR_ERR(&cx2072x->regmap);
dev_err(&i2c->dev, "Failed to init regmap: %d\n", ret);
return ret;
}
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
