On Fri, 14 Apr 2017 06:13:50 +0200,
Takashi Sakamoto wrote:
>
> In kernel APIs of ALSA control interface, drivers can create a control
> element set by a call of snd_ctl_new1() with a template. This template
> is known to have const qualifier in general cases.
>
> This commit adds the qualifier to template array, for safer program and
> runtime. Application of this change moves the symbol from .data section
> to .rodata section.
>
> Cc: Bhumika Goyal <bhumirks@xxxxxxxxx>
> Signed-off-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
Applied, thanks.
Takashi
> ---
> sound/usb/line6/pcm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/usb/line6/pcm.c b/sound/usb/line6/pcm.c
> index fab53f5..b3854f8 100644
> --- a/sound/usb/line6/pcm.c
> +++ b/sound/usb/line6/pcm.c
> @@ -430,7 +430,7 @@ static int snd_line6_control_playback_put(struct snd_kcontrol *kcontrol,
> }
>
> /* control definition */
> -static struct snd_kcontrol_new line6_controls[] = {
> +static const struct snd_kcontrol_new line6_controls[] = {
> {
> .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
> .name = "PCM Playback Volume",
> --
> 2.9.3
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
