On Thu, Apr 06, 2017 at 11:04:34AM +0800, simon.ho.cnxt@xxxxxxxxx wrote: > From: Simon Ho <simon.ho@xxxxxxxxxxxx> > > Initial commit of Conexant CX20921/CX20924 I2S Audio DSP driver > > The CX2092X devices are designed for virtual assisant application need to > be always open, listening for users to summon it. There is no any power > saving mode support on this device. The processed voice data will be sent > to automatic speech recognition (ASR) application for further processing. This is still fundamentally just passing undocumented commands straight through to the device (presumably to a firmware flashed onto the device since there's not even a firmware download happening) without any substantial integration with the rest of the system. That still doesn't really feel like a Linux driver at all, it seems more like it's just punching a hole through the Linux driver stack for proprietary software to do its thing. I'm also not clear how this can even implement always on speech recognition, there seems to be no interrupt support which I'd have thought would be a requirement. There are other vendors with voice processing features, the drivers for all these devices should be presenting interfaces that look similar to each other. What those drivers doing treaming the speech data to the host via a normal PCM which blocks while there's no speech data, that is much better integrated than this. You really need to address this, a big part of how Linux has got to where it is today is that it doesn't just have custom interfaces for each device but instead generalizes things so that we share good practice and features between devices and users can write Linux applications rather than vendor specific applications.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
