Re: [PATCH] ASoC: intel: Don't print FW version repeatedly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 27, 2017 at 11:13:54AM +0100, Mark Brown wrote:
> On Mon, Mar 27, 2017 at 03:36:58PM +0530, Vinod Koul wrote:
> > On Mon, Mar 27, 2017 at 10:39:58AM +0200, Takashi Iwai wrote:
> 
> > > -	dev_info(sst_drv_ctx->dev, "FW Version %02x.%02x.%02x.%02x\n",
> > > +	if (memcmp(&sst_drv_ctx->fw_version, &init->fw_version,
> > > +		   sizeof(init->fw_version)))
> 
> > wont dev_info_once be better here? We are really not expecting a new version
> > after suspend :)
> 
> You are if someone upgrades their userspace.

Ah yes thats a good point indeed, so:

Acked-by: Vinod Koul <vinod.koul@xxxxxxxxx>

Thanks
-- 
~Vinod
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux