Re: [PATCH] ASoC: wm8903: add regulator handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 20, 2017 at 12:51 PM, Charles Keepax
<ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Mar 20, 2017 at 10:13:52AM +0100, Linus Walleij wrote:

>> Mark: I was thinking about adding runtime PM for disabling
>> these regulators when unused, but I'm uncertain about the
>> interaction with DAPM in that regard. This atleast gives us
>> control over the supplies.
>
> DAPM will hold a pm_runtime reference whilst the chip is active
> so usually there isn't really much interaction to worry about.

OK, so since the codec is registered on i2c's client->dev I take
it I could use the runtime PM / suspend/resume callbacks on
that device, and it should just work.

> I think the patch looks fine for a first pass adding the supplies
> to me, someone can always add the suspend/resume and controlling
> the supplies across that when they need it.

I will make a try at this as a follow-on patch.

Yours,
Linus Walleij
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux