On Tue, Mar 21, 2017 at 1:26 AM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Tue, Mar 21, 2017 at 12:23:53AM +0800, Kai-Heng Feng wrote: >> On Tue, Mar 21, 2017 at 12:06 AM, Mark Brown <broonie@xxxxxxxxxx> wrote: > >> > As it says there "...and inserted automatically following the three dash >> > line". > >> I saw iteration changelog in git log all over the place, maybe add a >> rule section for each subsystem? > > Some people won't push back, the only people who insist on anything > different are the graphics people. Got it. I think the way you suggested is better. > >> I had the same thought originally, but printk under each case suggests >> otherwise - _POST_PMU is triggered not right after _PRE_PMU but right >> before _PRE_PMD. > > Then you've broken something else on your system, that is obviously > completely nonsensical and would break anything that relies on having a > _POST_PMU event. Why would we have two events that run at the same time > one of which is obviously misnamed? Hmm, that's weird though. I did the same test to rt286_spk_event() (without applying the patch I sent), what I observed was the same: _POST_PMU was triggered right after I stopped play sound, i.e. right before _PRE_PMD not right after _PRE_PMU. > >> > > You didn't reply to my review comment and you sent the same code >> > > again. >> > That looks an awful lot like being ignored. > >> Fair enough, I thought changelog is sufficient. > > I'm not seeing anything in the changelog that addresses this. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
