> -----Original Message----- > From: Kai-Heng Feng [mailto:kai.heng.feng@xxxxxxxxxxxxx] > Sent: Monday, March 20, 2017 11:59 AM > To: broonie@xxxxxxxxxx > Cc: lgirdwood@xxxxxxxxx; Bard Liao; Oder Chiou; > alsa-devel@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Kai-Heng Feng > Subject: [PATCH v3] ASoC: rt286: fix headphone click/crack noise on Dell XPS > 9343 I2S mode > > + switch (event) { > + case SND_SOC_DAPM_PRE_PMD: > + case SND_SOC_DAPM_POST_PMD: > + case SND_SOC_DAPM_POST_PMU: > + snd_soc_write(codec, RT286_SET_AMP_GAIN_HPO, > AMP_OUT_MUTE); > + break; > + case SND_SOC_DAPM_PRE_PMU: > + snd_soc_write(codec, RT286_SET_AMP_GAIN_HPO, > AMP_OUT_UNMUTE); > + break; Besides Mark's comment, I have question here. It seems you want to mute HPO before "HP Power" is powered up and after "HP Power" is powered down. But "HPO L" and "HPO R" are autodisable. And "HP Power" is only connect to "HPO L" and "HPO R". From my understanding, HPO will mute if "HP Power" is powered down. Any specific reason for muting HPO again before "HP Power" is powered up? Will HPO be unmuted before "HP Power" is powered up on your system? Or should the event be associated with "LDO1"? Which power will cause the click noise? _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
