Re: [PATCH v4 6/9] ASoC: add snd_soc_get_dai_id()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob

Thank you for your review

> > +{
> > +       struct device_node *node;
> > +       struct device_node *endpoint;
> > +       int i, id;
> > +
> > +       node = of_graph_get_port_parent(ep);
> > +
> > +       i = 0;
> > +       id = -1;
> > +       for_each_endpoint_of_node(node, endpoint) {
> > +               if (endpoint == ep)
> > +                       id = i;
> 
> I don't see how this works when you have 1 DAI controller with
> multiple endpoints versus multiple DAI controllers with a single
> endpoint each. All the IDs will be 0 in the latter case.

It support 1:1 endpoint pattern only.

Best regards
---
Kuninori Morimoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux