Re: [PATCH] ASoC: core: remove redundunt address operation for array type variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 13, 2017 at 12:07:43PM +0900, Takashi Sakamoto wrote:

> These two evaluation have the same value, a pointer to the first element
> of the array.

> This kind of address operation is not good for readers, because it easily
> brings confusions as an address operations to pointers. For example,

This is done explicitly for clarity, in order to make it clear that the
value is a pointer rather than being (say) an integer.  The value is the
same as you say but that's only clear if the reader realizes that data
is an array.  If I were clarifying this I'd change to explicitly take
the address of the first element of the array rather than the array as
a whole. 

> Cc: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
> Fixes: f831b055ecec ("ASoC: core: Add support for masking out parts of coefficient blocks")

This is a style change rather than a fix.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux