On Tue, 2017-03-07 at 13:36 +0100, Mark Brown wrote: > On Mon, Mar 06, 2017 at 06:44:50PM +0100, Jerome Brunet wrote: > > > + gpiod_set_value(priv->gpiod_enable, val); > > You should use gpiod_set_value_cansleep() so that the driver can work > with all GPIOs unless there's a specific need to have GPIOs you can > control in interrupt (which should be the case for anything you're > using > for DAPM control). Indeed, Thanks for pointing this out. I have question regarding this DAPM control. Here, I put the control in DAPM so it can help with the pop noise reduction, but I think it would be nice if the user could force the mute if he wants to. Would it be OK to add a user control and some logic so the output is enabled only if DAPM and the user agree it should ? > > Please submit an incremental patch fixing this. Done _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
