There is no point to always return 0. Convert sst_shim_write() and sst_shim_write64() to return void. No caller is checking for return value. Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> --- sound/soc/intel/atom/sst/sst.h | 4 ++-- sound/soc/intel/atom/sst/sst_pvt.c | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/sound/soc/intel/atom/sst/sst.h b/sound/soc/intel/atom/sst/sst.h index c585b07925f8..f00c13d53d23 100644 --- a/sound/soc/intel/atom/sst/sst.h +++ b/sound/soc/intel/atom/sst/sst.h @@ -534,9 +534,9 @@ u32 relocate_imr_addr_mrfld(u32 base_addr); void sst_add_to_dispatch_list_and_post(struct intel_sst_drv *sst, struct ipc_post *msg); int sst_pm_runtime_put(struct intel_sst_drv *sst_drv); -int sst_shim_write(void __iomem *addr, int offset, int value); +void sst_shim_write(void __iomem *addr, int offset, int value); u32 sst_shim_read(void __iomem *addr, int offset); -int sst_shim_write64(void __iomem *addr, int offset, u64 value); +void sst_shim_write64(void __iomem *addr, int offset, u64 value); u64 sst_shim_read64(void __iomem *addr, int offset); void sst_set_fw_state_locked( struct intel_sst_drv *sst_drv_ctx, int sst_state); diff --git a/sound/soc/intel/atom/sst/sst_pvt.c b/sound/soc/intel/atom/sst/sst_pvt.c index 2452cbd77033..00d58f41231a 100644 --- a/sound/soc/intel/atom/sst/sst_pvt.c +++ b/sound/soc/intel/atom/sst/sst_pvt.c @@ -39,10 +39,9 @@ #include "sst.h" #include "../../common/sst-dsp.h" -int sst_shim_write(void __iomem *addr, int offset, int value) +void sst_shim_write(void __iomem *addr, int offset, int value) { writel(value, addr + offset); - return 0; } u32 sst_shim_read(void __iomem *addr, int offset) @@ -50,10 +49,9 @@ u32 sst_shim_read(void __iomem *addr, int offset) return readl(addr + offset); } -int sst_shim_write64(void __iomem *addr, int offset, u64 value) +void sst_shim_write64(void __iomem *addr, int offset, u64 value) { lo_hi_writeq(value, addr + offset); - return 0; } u64 sst_shim_read64(void __iomem *addr, int offset) -- 2.11.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel