Re: [PATCH v2 1/4] ASoC: rt5660: Add ACPI support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 13, 2017 at 4:53 AM, Bard Liao <bardliao@xxxxxxxxxxx> wrote:
>> +static const struct acpi_gpio_mapping byt_rt5660_gpios[] = {
>> +     { "audio-wake-intr-gpios", &audio_wake_intr_gpio, 1 },
>> +     { "lineout-mute-gpios", &lineout_mute_gpio, 1 },
>> +     { NULL },
>> +};
>> +
>
> I am thinking if it is more suitable to move the gpio params to
> machine driver? They are not codec's gpios and are only used
> by machine driver.

Generally speaking those properties should come per ACPI ID. So, they
should share the same module which has MODULE_DEVICE_TABLE(acpi, ...)
defined.

-- 
With Best Regards,
Andy Shevchenko
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux