On Dec 13 2016 08:25, Takashi Iwai wrote:
Actually I took the second one (the removal of unused variables), as it's a good cleanup. But the first one, the change of the type, is in a gray zone, and I'd like to leave such a thing. Changing the loop variable like i to unsigned int is rather confusing, and it may be a source of bugs if anyone reuses i for another loop. The warning is merely an annoyance, and IMO, we just should suppress the compile warning like the kernel does. The third patch, the removal of the unused table, is postponed because I don't know whether it's intentional or overlook unless confirmation from Intel people.
OK. I wait for their ack about these two patches. Thanks for your reviewing!
[PATCH][alsa-lib] topology: fix sign-compare warning introduced to set_link_hw_config() and tplg_add_link_object() http://mailman.alsa-project.org/pipermail/alsa-devel/2016-November/115245.html [PATCH][alsa-lib] topology: fix unused-variable warnings introduced to build_link() http://mailman.alsa-project.org/pipermail/alsa-devel/2016-November/115246.html [PATCH][alsa-lib] topology: fix unused-const-variable warning http://mailman.alsa-project.org/pipermail/alsa-devel/2016-November/115247.html
Gute Nacht. Takashi Sakamoto _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
