On Thursday 08 December 2016 13:36:12 Michał Kępień wrote:
> As dell_micmute_led_set() no longer uses the dell_wmi_perform_query()
> method, which was removed in 0c41a08 ("dell-led: use
> dell_smbios_send_request() for performing SMBIOS calls"), the
> DELL_APP_GUID check is redundant and thus can be safely removed.
>
> Signed-off-by: Michał Kępień <kernel@xxxxxxxxxx>
> ---
> drivers/leds/dell-led.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/leds/dell-led.c b/drivers/leds/dell-led.c
> index b3d6e9c..e8e8f67 100644
> --- a/drivers/leds/dell-led.c
> +++ b/drivers/leds/dell-led.c
> @@ -51,9 +51,6 @@ static int dell_micmute_led_set(int state)
> struct calling_interface_buffer *buffer;
> struct calling_interface_token *token;
>
> - if (!wmi_has_guid(DELL_APP_GUID))
> - return -ENODEV;
> -
> if (state == 0)
> token = dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE);
> else if (state == 1)
Reviewed-by: Pali Rohár <pali.rohar@xxxxxxxxx>
Anyway, you can remove DELL_APP_GUID from other places too...
--
Pali Rohár
pali.rohar@xxxxxxxxx
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
